<html>
<head><meta charset="utf-8"><title>Seeking advice on structuring PR · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Seeking.20advice.20on.20structuring.20PR.html">Seeking advice on structuring PR</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="227078433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Seeking%20advice%20on%20structuring%20PR/near/227078433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Nguyen <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Seeking.20advice.20on.20structuring.20PR.html#227078433">(Feb 20 2021 at 09:00)</a>:</h4>
<p>I'm currently hunting down places where <code>for</code> + <code>insert</code>-style loops can be replaced with a single <code>extend()</code> or <code>collect()</code>. I've already found a couple, but they're in different parts of the compiler.</p>
<p>Is it okay to aggregate the changes in a single PR, or should I try to split them up?</p>



<a name="227078986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Seeking%20advice%20on%20structuring%20PR/near/227078986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Seeking.20advice.20on.20structuring.20PR.html#227078986">(Feb 20 2021 at 09:12)</a>:</h4>
<p>Assuming it's easy to look at the refactor and see that it's correct, I suspect there's no issue with one PR.</p>
<p>If it ends up touching more of the related code, then splitting might be better -- especially if it introduces/remove calls to crate-specific things.</p>



<a name="227079096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/Seeking%20advice%20on%20structuring%20PR/near/227079096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Nguyen <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/Seeking.20advice.20on.20structuring.20PR.html#227079096">(Feb 20 2021 at 09:15)</a>:</h4>
<p>Okay, I think the changes are pretty self-contained, so I'll probably go with a single PR. Thanks for the help!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>